feat: handle player id, name on both frontend and backend #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions to manage players
…, client, server with 1 command
Aleks334
dismissed
mit3r’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds storing player id on frontend and retrieving it on backend. Also name is passed to backend when player enters to lobby and confirms modal by entering name.
There's also some refactoring related to frontend and backend folder structure.
Modal component doesn't have animations. It's tricky to implement them with motion (or with css animations) for dialog html element. It's hard to style backdrop as it is pseudo element. Moreover close() method from dialog api should be deferred to see exit anim (it modifies also display property) . Due to that i leave it without any animations.
Other issues linked with this feature: #29, #23